Fixing the conversion for the "new" ing CSV format. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…now the semicolon, so there is no need to merge two value fields. However, fields need to be renumbered as there is now one less, and the value field needs to have the comma replaced by a colon to allow the conversion to float.
Fixing the conversion for the "new" ing CSV format. The separator is now the semicolon, so there is no need to merge two value fields. However, fields need to be renumbered as there is now one less, and the value field needs to have the comma replaced by a colon to allow the conversion to float. Corrected so that if the origin account is empty, the description is used instead Based on work from TheoMarescaux (https://github.com/TheoMarescaux/ofxstatement-be-ing)
Fixed several formatting errors
Reference README.md instead of README.rst
Added "test" options for Travis
Removed extra "long_description" entry
I am still missing unit tests.
Removed Travis badge, to be re-added after I have the unit tests working
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The separator is now the semicolon, so there is no need to merge two value fields. However, fields need to be renumbered as there is now one less, and the value field needs to have the comma replaced by a colon to allow the conversion to float.
Building on abiggerhammer's pull request.